Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a
Parsers.jl
-based parser implementation #80Use a
Parsers.jl
-based parser implementation #80Changes from 8 commits
ca33748
beaed86
8fef453
9b3965b
2031da9
3335432
e6b892b
1066e65
99ca92e
2d0c28b
838e138
a77e345
0ce31ce
a47b3d7
4885df0
f9a7bd8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not something for right now, but just sharing this because it's so super freaking cool:
#45
Todd came up with this approach to improve the performance of dividing by power of ten. Basically the idea is that you can skip the
div
, which is a very expensive operation, by instead multiplying by (2^64 / 10 / 2^64), and since you can precompute2^64 / 10
as a constant, and then/ 2^64
can be done by just a bit-shift, you can skip the divide. Really clever!But I never managed to merge that PR, so............................. :)
I think we just leave that optimization aside here too, but it's fun and something cool to think about for the future! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm not understanding the comment quite right, but this makes it sound like it's backwards; I was expecting a phrase like "if any digits are past our precision, overflow is possible" or the inverse of "No digits are past our precision, so no overflow possible"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overflow is not possible here but inexact error is possible if we're not okay with rounding. In my mind overflow is when we try to parse "130"
FD{Int8,0}
and inexact would happen if we tried to parse "100.1" asFD{Int8,0}