Fix beta_inc_inv bug introduced in #399
#401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
=======================================
Coverage 93.60% 93.60%
=======================================
Files 12 12
Lines 2769 2769
=======================================
Hits 2592 2592
Misses 177 177
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
LGTM. |
devmotion
added a commit
that referenced
this pull request
Jun 1, 2022
stevengj
pushed a commit
that referenced
this pull request
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, #399 accidentally broke
beta_inc_invfor some values, as reported in JuliaStats/StatsFuns.jl#145.The main issue seems to be that the initial
xbecame much smaller in some cases (see #399 (comment)). Increasing the lower bound significantly (the proposed1e-200in #396 is not sufficient), e.g., toeps(Float64), fixes JuliaStats/StatsFuns.jl#145.However, for now I just reverted that change completely since it seems it is not needed for the bug fix in #399.