This repository has been archived by the owner on Apr 9, 2020. It is now read-only.
Added support for views and subarrays, updated tests, added sumabs for Float32 #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found this package quite useful, but it seems to lack support for common types such as views of arrays. Hope you like it.
Notable things:
I added
_iscontiguous
to verify is aStridedArray
is contiguous, and a fallback forStridedArray
to false, there are probably better ways to check this? Maybe someone with better knowledge of the julia internals can comment on this?Removed the argument specification
Array
onadd
andsubtract
. They were inconsistent with the other wrappers. Maybe they should all beAny
as most of them were, or something a bit more stringent?Added
sumabs
forFloat32
. I was not able to find the source to verify that this should work, but it seems to pass the tests.Kept the requirement on arguments being vectors for
dot
, this is not the case in Base, so maybe it can be relaxed (but this is an orthogonal problem)Updated
evalpoly.jl
to work on julia 1.0, although this code is not run automatically on tests (could also be separate issue)EDIT: Tests fails on osx, I am not sure what is going on here, is it a build problem? Last test was run 8 months ago.