Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Properly (de)serialize VersionSpec to JSON" #98

Merged
merged 1 commit into from
Jan 9, 2021

Conversation

giordano
Copy link
Member

@giordano giordano commented Jan 9, 2021

Reverts #93. It breaks registration of LLVM: https://dev.azure.com/JuliaPackaging/Yggdrasil/_build/results?buildId=8363&view=logs&j=82ede541-d8dc-5eb8-fd6b-5903678e9282&t=31eefa9e-75b0-5107-6058-36e5c2f2fd84

    Updating registry at `/depot/registries/General`
Downloading sources...
ERROR: LoadError: KeyError: key "ranges" not found
Stacktrace:
  [1] getindex
    @ ./dict.jl:482 [inlined]
  [2] dejson(#unused#::Type{Pkg.Types.VersionSpec}, d::Dict{String, Any})
    @ BinaryBuilderBase /depot/packages/BinaryBuilderBase/OykWl/src/Dependencies.jl:130
  [3] dependencify(d::Dict{String, Any})
    @ BinaryBuilderBase /depot/packages/BinaryBuilderBase/OykWl/src/Dependencies.jl:138
  [4] _broadcast_getindex_evalf
    @ ./broadcast.jl:648 [inlined]
  [5] _broadcast_getindex
    @ ./broadcast.jl:621 [inlined]
  [6] getindex
    @ ./broadcast.jl:575 [inlined]
  [7] copy(bc::Base.Broadcast.Broadcasted{Base.Broadcast.DefaultArrayStyle{1}, Tuple{Base.OneTo{Int64}}, typeof(BinaryBuilderBase.dependencify), Tuple{Vector{Any}}})
    @ Base.Broadcast ./broadcast.jl:922
  [8] materialize
    @ ./broadcast.jl:883 [inlined]
  [9] cleanup_merged_object!(meta::Dict{Any, Any})
    @ BinaryBuilder /depot/packages/BinaryBuilder/yQq4Z/src/Declarative.jl:33
 [10] top-level scope
    @ /agent/_work/1/s/.ci/download_sources.jl:14
in expression starting at /agent/_work/1/s/.ci/download_sources.jl:14

CC: @fingolfin

@fingolfin
Copy link
Member

Huh, weird -- can one see the meta.json that got used there somehow?

@giordano
Copy link
Member Author

giordano commented Jan 9, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants