Skip to content

Commit

Permalink
[MbedTLS]: Fix lack of +x permissions on DLLs (#2105)
Browse files Browse the repository at this point in the history
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
  • Loading branch information
staticfloat and giordano committed Nov 13, 2020
1 parent b7d5c0f commit ab88c17
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions M/MbedTLS/build_tarballs.jl
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,14 @@ cmake -DCMAKE_INSTALL_PREFIX=${prefix} \
-DUSE_SHARED_MBEDTLS_LIBRARY=On \
..
make -j${nproc} && make install
if [[ "${target}" == *mingw* ]]; then
# For some reason, the build system doesn't set the `.dll` files as
# executable, which prevents them from being loaded. Also, we need
# to explicitly use `${prefix}/lib` here because the build system
# is a simple one, and blindly uses `/lib`, even on Windows.
chmod +x ${prefix}/lib/*.dll
fi
"""

# These are the platforms we will build for by default, unless further
Expand Down

1 comment on commit ab88c17

@stillyslalom
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this commit have caused JuliaLang/MbedTLS.jl#229 / JuliaLang/julia#38409?

Please sign in to comment.