Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Julia_jll 1.4.1 binary for macOS contains wrong header files #1372

Closed
fingolfin opened this issue Jul 30, 2020 · 2 comments · Fixed by #2315
Closed

Julia_jll 1.4.1 binary for macOS contains wrong header files #1372

fingolfin opened this issue Jul 30, 2020 · 2 comments · Fixed by #2315
Labels
julia 💜 ❤️ 💚 Builders and issues related to Julia and its dependencies

Comments

@fingolfin
Copy link
Member

The file Julia.v1.4.1.x86_64-apple-darwin14-libgfortran4-cxx11.tar.gz contains the wrong header files. For example, it has this julia_version.h:

// This is an autogenerated header file
#ifndef JL_VERSION_H
#define JL_VERSION_H
#define JULIA_VERSION_STRING "1.6.0-DEV"
#define JULIA_VERSION_MAJOR 1
#define JULIA_VERSION_MINOR 6
#define JULIA_VERSION_PATCH 0
#define JULIA_VERSION_IS_RELEASE 0
#endif

There are other diffs compared to the actual Julia 1.4.1 headers.

The headers seem fine in 1.4.2.

However, all packages in Yggdrasil using Julia_jll right now specifically ask for Julia_jll 1.4.1, so perhaps this should still be addressed?
This was referenced Aug 7, 2020
Merged
Merged
@giordano giordano added the julia 💜 ❤️ 💚 Builders and issues related to Julia and its dependencies label Sep 24, 2020
@fingolfin
Copy link
Member Author

I wonder if we should just withdraw Julia_jll? If one can even do that... ah well shrug

@vchuravy
Copy link
Member

Yes you can yank all versions, better than leaving something broken around.

fingolfin added a commit to fingolfin/Yggdrasil that referenced this issue Dec 29, 2020
@fingolfin
Remove Julia_jll builders
644d7ec 
These are a dead end in the current form, packages should instead
use libjulia_jll. Better not to leave these in, otherwise people
may end up wasting time trying to use this.

Closes JuliaPackaging#1372
@fingolfin fingolfin mentioned this issue Dec 29, 2020
Merged
giordano pushed a commit that referenced this issue Dec 29, 2020
@fingolfin
Remove Julia_jll builders (#2315)
b0bf1c6 
These are a dead end in the current form, packages should instead
use libjulia_jll. Better not to leave these in, otherwise people
may end up wasting time trying to use this.

Closes #1372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
julia 💜 ❤️ 💚 Builders and issues related to Julia and its dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Julia_jll builders fingolfin/Yggdrasil
3 participants
@vchuravy @fingolfin @giordano