Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild libcxxwrap_julia against latest libjulia_jll #2150

Merged
merged 1 commit into from
Nov 21, 2020

Conversation

fingolfin
Copy link
Member

Do not merge this just yet, I want to test the macOS binary to see if it actually solves the issues there.

I've incremented the version as otherwise I am not sure we can rely on everybody receiving the fix? But perhaps this is not actually necessary?

CC @barche

@fingolfin
Copy link
Member Author

I've now tested the macOS binaries on my computer, with help of ~/.julia/artifacts/Overrides.toml, and everything seems to work fine now!

The only thing I am unsure about is whether to change the version (as this PR does not right now) or else leave it... @barche @giordano advice?

@fingolfin fingolfin marked this pull request as ready for review November 20, 2020 23:01
@giordano
Copy link
Member

The only thing I am unsure about is whether to change the version (as this PR does not right now) or else leave it... @barche @giordano advice?

We're going to decouple the JLL version from the upstream one, so versioning it's mostly up to you. In particular we want to not use build versions going forward, so the safest option is to bump the patch version.

Other the version number (which looks ok to me), I take this can be merged?

@fingolfin
Copy link
Member Author

From my POV it is ready for merging

@vchuravy vchuravy merged commit 3e84b3c into JuliaPackaging:master Nov 21, 2020
@fingolfin fingolfin deleted the mh/libcxxwrap branch November 21, 2020 21:11
@barche
Copy link
Contributor

barche commented Nov 21, 2020

OK, since the versions are decoupled now anyway I guess it's most logical to just go ahead and base the JLLs for julia 1.4 and 1.5 also on libcxxwrap-julia 0.8.2?

@fingolfin
Copy link
Member Author

@barche they all will be based on the same git commit of libcxxwrap-julia, if you mean that? But that was always the plan, wasn't it?

@barche
Copy link
Contributor

barche commented Nov 21, 2020

Well, I was going to bump the upstream versions in sync, but actually it's better not to. This way, if bugs are fixed we can just update all JLLs. So basically nothing is holding back the creation of the other JLLs now, I think.

@fingolfin
Copy link
Member Author

@barche exactly -- see also PR #2106 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants