Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libsingular-julia]: version v0.2.2 #2203

Closed
wants to merge 2 commits into from

Conversation

thofma
Copy link
Contributor

@thofma thofma commented Dec 1, 2020

@fingolfin: @fieker wants to use the new version now. I think we should not wait for #1798.

@fieker
Copy link

fieker commented Dec 1, 2020 via email

@thofma
Copy link
Contributor Author

thofma commented Dec 1, 2020

This PR is good to go.

@thofma thofma marked this pull request as draft December 1, 2020 15:35
@fingolfin
Copy link
Member

@thofma You first commented "this is good to go", then marked this as a draft, so I guess it is not good to go after all?

@thofma
Copy link
Contributor Author

thofma commented Dec 2, 2020

No, there are some issues that need to be resolved (libsingular-julia is fine, but we don't know yet if we need to put in more changes).

@fingolfin
Copy link
Member

There is of course also PR #1798 which also updates libsingular_julia_jll -- I'd rather continue with that. We could also hold back both that and this PR to wait until we created new FLINT_jll (#2234) and Singular_jll versions and then migrated to them?

@thofma
Copy link
Contributor Author

thofma commented Dec 8, 2020

I am fine with continuing this at #1798. But I don't know how long this will take and how long @fieker wants to wait.

@thofma thofma deleted the patch-18 branch September 14, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants