Update libpolymake_julia (for Julia 1.3) #2306
Conversation
| BuildDependency(PackageSpec(name="GMP_jll", version=v"6.1.2")), | ||
| BuildDependency(PackageSpec(name="MPFR_jll", version=v"4.0.2")), | ||
| ] | ||
|
|
||
| # Build the tarballs, and possibly a `build.jl` as well. | ||
| build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies; preferred_gcc_version=v"7") | ||
| build_tarballs(ARGS, name, version, sources, script, platforms, products, dependencies; | ||
| preferred_gcc_version=v"8", |
There was a problem hiding this comment.
We need GCC 8 or newer to make sure to avoid that libcxxwrap bug (but @benlorenz discovered this, so he's aware -- I just wanted to call this change out, so it doesn't slip by).
fingolfin
force-pushed
the
mh/libpolymake_julia-1.3
branch
2 times, most recently
from
1603de7
to
c6b52cf
Compare
fingolfin
force-pushed
the
mh/libpolymake_julia-1.3
branch
from
c6b52cf
to
dd8d76a
Compare
L/libpolymake_julia/common.jl
Outdated
| @@ -5,11 +5,12 @@ import Pkg: PackageSpec | |||
| import Pkg.Types: VersionSpec | |||
|
|
|||
| name = "libpolymake_julia" | |||
| version = v"0.3.0" | |||
| version = VersionNumber(0, 4, julia_version.minor) | |||
There was a problem hiding this comment.
Note this quirky version -- we should have something newer than 0.3, so at least 0.4; but at this point, we are decoupling from the upstream version anyway, so we might as well use 3.0 or 4.0 or whatever else strikes your fancy.
I would also in general like to float the idea of not bothering with on upstream libpolymake-julia, and instead use a GitSource below. At least I fail to see any benefit from having a version there? It just adds extra work?
There was a problem hiding this comment.
There is an extra version information in the library headers that is checked at runtime which I like to keep that way as a failsafe and for people using overrides. So I will update that to 0.4 and create a new tag.
Also we do have full control over the upstream versions here so there is really no need for decoupling the version.
Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
|
@giordano please merge? |
This won't compile succesfully until #2304 is merged and in the registry.
But I wanted to get it out here right away to (a) have it of my plat and (b) to maximize the time @benlorenz has to look at it.