Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CGAL] Update to v5.2 #2331

Merged
merged 4 commits into from
Dec 30, 2020
Merged

[CGAL] Update to v5.2 #2331

merged 4 commits into from
Dec 30, 2020

Conversation

rgcv
Copy link
Contributor

@rgcv rgcv commented Dec 30, 2020

Removes specific version coupling to its dependencies since it doesn't
appear to be much of an issue which version gets to be picked, be it the
latest or the minimum supported version.

Removes specific version coupling to its dependencies since it doesn't
appear to be much of an issue which version gets to be picked, be it the
latest or the minimum supported version.
@giordano
Copy link
Member

This looks good, I'm just waiting to understand whether it's necessary to merge #2329 before this one

C/CGAL/build_tarballs.jl Outdated Show resolved Hide resolved
C/CGAL/build_tarballs.jl Outdated Show resolved Hide resolved
As suggested, this string can then be fed to `VersionNumber` to create a
proper semver type instance.
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@giordano giordano merged commit 67b4616 into JuliaPackaging:master Dec 30, 2020
@rgcv rgcv deleted the cgal branch December 31, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants