Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NetCDF] Expand platforms for NetCDF. #5429

Closed
wants to merge 2 commits into from

Conversation

evetion
Copy link
Contributor

@evetion evetion commented Sep 4, 2022

So #5383 can use NetCDF on Windows. Might be a long shot, or a misunderstanding of mine.

@evetion evetion marked this pull request as ready for review September 4, 2022 19:01
@evetion
Copy link
Contributor Author

evetion commented Sep 4, 2022

That was easier than I thought 😅

@giordano
Copy link
Member

giordano commented Sep 4, 2022

I'm missing the point of this PR. Also, please do not add commits (like merges) which don't change the content of the directory: they're useless and only make it harder for me to find the log

@evetion
Copy link
Contributor Author

evetion commented Sep 4, 2022

Over at #5383, many of the builds https://dev.azure.com/JuliaPackaging/Yggdrasil/_build/results?buildId=21939&view=results warn about ##[warning]Dependency NetCDF_jll does not have a mapping for artifact NetCDF for platform x86_64-w64-mingw32-libgfortran4-cxx11

I assume this PR could fix that.

@giordano
Copy link
Member

giordano commented Sep 4, 2022

I don't think so

@giordano
Copy link
Member

giordano commented Sep 4, 2022

The log shows that v400.802.102+0 was used, which simply does not have Windows build. C++ string ABI has nothing to do with this.

@giordano giordano closed this Sep 4, 2022
@evetion evetion deleted the feat/netcdf-platforms branch September 5, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants