Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align openssl version with OpenSSL_jll version #140

Merged
merged 4 commits into from
Jul 20, 2024

Conversation

lassepe
Copy link
Contributor

@lassepe lassepe commented Jul 14, 2024

As suggested by @cjdoris on discourse, I implemented a similar version bound adaption for OpenSSL_jll as is already used for libstdc++.

The main things that I am uncertain about is:

  • Can we trust that all openssl versions within the same minor version are compatible as I did in this PR? They don't seem to be following semver (?)
  • Pkg.dependencies() is considered experimental so we may not want to rely on it. Alternatively, we could rely on Pkg.installed() which is deprecated. Actually, Pkg.installed() does not consider transitive dependencies so the only other option I can think of is to the Manifest.toml manually (?)

x-ref:

@cjdoris cjdoris merged commit da6a637 into JuliaPy:main Jul 20, 2024
8 checks passed
@cjdoris
Copy link
Collaborator

cjdoris commented Jul 20, 2024

Thanks very much! I tweaked the version bound logic a bit (I think it's now consistent with the OpenSSL release strategy) before merging, and added a note to the changelog. Will make a release shortly.

@lassepe lassepe deleted the fix/align_openssl_version branch July 20, 2024 22:43
@lassepe
Copy link
Contributor Author

lassepe commented Jul 20, 2024

Thank you for pushing this over the finish line :) Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants