Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename split function #179

Closed
lucaferranti opened this issue Sep 28, 2021 · 1 comment · Fixed by #183
Closed

rename split function #179

lucaferranti opened this issue Sep 28, 2021 · 1 comment · Fixed by #183

Comments

@lucaferranti
Copy link
Member

lucaferranti commented Sep 28, 2021 •
edited
Loading

The current function split computes the midpoint and radius matrix of the interval matrix. Maybe the current name is a little misleading? By the name, I would think it does something like bisect or mince.

IntervalArithmetic.jl has a function called midpoint_radius which does exactly what split currently does, maybe we can extend that function?
@mforets
Copy link
Member

mforets commented Sep 28, 2021

makes sense to rename to midpoint_radius if that's used instead of split in IA 👍

lucaferranti added a commit that referenced this issue Sep 30, 2021
@lucaferranti
renamed split -> midpoint_radius, fixes #179
aea0c54
@lucaferranti lucaferranti linked a pull request Sep 30, 2021 that will close this issue
renamed split -> midpoint_radius, fixes #179 #183
Merged
mforets pushed a commit that referenced this issue Sep 30, 2021
@lucaferranti
renamed split -> midpoint_radius, fixes #179 (#183)
fb6a5f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

renamed split -> midpoint_radius, fixes #179 JuliaReach/IntervalMatrices.jl
2 participants
@mforets @lucaferranti