Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor matrix.jl #178

Merged
merged 3 commits into from
Sep 28, 2021
Merged

refactor matrix.jl #178

merged 3 commits into from
Sep 28, 2021

Conversation

lucaferranti
Copy link
Member

@lucaferranti lucaferranti commented Sep 28, 2021 •
edited
Loading

fixes #174

current structure

  • operations
    • arithmetic.jl (as before, but scale moved here)
    • norm.jl: functionalities to compute norms (does this fit better here or in ILA?)
    • numops.jl: function returning non-interval valued matrices (inf, sup, diam, radius, mid, split)
    • random.jl: functionalities with random (sample and rand)
    • setops.jl : set operations (in, subseteq, union, hull, intersect)
    • power.jl: moved here unchanged

schillic
schillic reviewed Sep 28, 2021
View reviewed changes
Copy link
Member

@schillic schillic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are indentation problems in random.jl. The rest looks good, thanks!

@mforets mforets merged commit 6d130cf into master Sep 28, 2021
@mforets mforets deleted the lf-174 branch September 28, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schillic schillic schillic approved these changes

@mforets mforets mforets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restructure matrix.jl
3 participants
@lucaferranti @schillic @mforets