Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: InverseFunctions v0.1.16 #112881

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 3587e190-3f89-42d0-90ee-14403ec27112
Repo: https://github.com/JuliaMath/InverseFunctions.jl.git
Tree: 2787db24f4e03daf859c6509ff87764e4182f7d1

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Copy link
Contributor

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. AutoMerge Guidelines are all met! ✅

Your new version registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round.

2. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@aplavin
Copy link
Contributor

aplavin commented Aug 11, 2024

IMHO, some more care should be excercised when turning stdlib deps into weakdeps for such packages that are potentially deep in dependency trees. Given that there are known Julia issues with weakdep loading order / stdlib extensions.
Details in PR JuliaMath/InverseFunctions.jl#52.

But ofc feel free to merge if you think these concerns are unfounded...

@ChrisRackauckas
Copy link
Member

The example you're pointing to shows Accessors.jl, not this package. I don't see any evidence of this package and this extension having an issue, just vaguely maybe related (but most likely not) issues with other packages.

@ChrisRackauckas ChrisRackauckas merged commit 4c0f8a6 into master Aug 11, 2024
17 checks passed
@ChrisRackauckas ChrisRackauckas deleted the registrator-inversefunctions-3587e190-v0.1.16-35b6f21683 branch August 11, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants