Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: NNlibCUDA v0.1.0 #32119

Merged
merged 1 commit into from
Apr 17, 2021

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Mar 16, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2021

Your new package pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

Since you are registering a new package, please make sure that you have read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@DilumAluthge
Copy link
Member

DilumAluthge commented Mar 16, 2021

[noblock]

@DhairyaLGandhi @CarloLucibello Is it expected that this package fails to import?

Generally, I recommend that a package is always importable, even if, for example, a CUDA GPU is not available. This is how CUDA.jl works - you can do import CUDA even if a CUDA GPU is not available.

If that is not possible, an alternate approach would be to check for the JULIA_REGISTRYCI_AUTOMERGE environment variable. AutoMerge will set the JULIA_REGISTRYCI_AUTOMERGE environment variable to true. So you can check for that, and skip certain steps if you detect that the package is being imported on AutoMerge.

@DilumAluthge
Copy link
Member

[noblock]

Disregard the above comment. Per FluxML/NNlib.jl#300 (comment), the import failures are due to the fact that CUDA 3.0.0 is not yet registered.

@DhairyaLGandhi
Copy link
Contributor

[noblock]

Yeah, that seems to be the case. Should we be able to register a package with unreleased dependencies?

@DilumAluthge
Copy link
Member

DilumAluthge commented Mar 16, 2021

Blocking this until we make a decision on FluxML/NNlib.jl#300 (comment)

[noblock]

@DhairyaLGandhi
Copy link
Contributor

DhairyaLGandhi commented Mar 17, 2021

[noblock]

Could we not block it maybe? We can review the structure but moving it to its repo should be legal no?

@DilumAluthge
Copy link
Member

[noblock]

If we change the URL, we need to make sure that all registered versions exist at the new URL, which means that the new URL needs to have all of the same Git trees available.

@CarloLucibello
Copy link
Contributor

[noblock]

If we change the URL, we need to make sure that all registered versions exist at the new URL, which means that the new URL needs to have all of the same Git trees available.

@DilumAluthge this means that if we want to move NNlibCUDA to a separate repo we just push NNlib´s master to the new remote and then remove everything not NNlibCUDA related, right?

@giordano
Copy link
Member

giordano commented Apr 9, 2021

Correct

[noblock]

@JuliaRegistrator JuliaRegistrator force-pushed the registrator/nnlibcuda/a00861dc/v0.1.0 branch from 8774e8b to 18a18b6 Compare April 16, 2021 15:48
JuliaRegistrator referenced this pull request in FluxML/NNlibCUDA.jl Apr 16, 2021
Add TagBot and CompatHelper
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch April 16, 2021 15:50 Inactive
@DilumAluthge
Copy link
Member

@DhairyaLGandhi You need a license.

[noblock]

UUID: a00861dc-f156-4864-bf3c-e6376f28a68d
Repo: https://github.com/FluxML/NNlibCUDA.jl.git
Tree: 4b368b466bcdd25d448a5b20de4b7e481d68b88e

Registrator tree SHA: e934b8c55381f28735124f23e8f7e96d09b20416
@JuliaRegistrator JuliaRegistrator force-pushed the registrator/nnlibcuda/a00861dc/v0.1.0 branch from 18a18b6 to 3899e92 Compare April 17, 2021 13:06
JuliaRegistrator referenced this pull request in FluxML/NNlibCUDA.jl Apr 17, 2021
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch April 17, 2021 13:07 Inactive
@JuliaTagBot JuliaTagBot merged commit a4b90c1 into master Apr 17, 2021
@JuliaTagBot JuliaTagBot deleted the registrator/nnlibcuda/a00861dc/v0.1.0 branch April 17, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants