Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Xsum v1.2.0 #36934

Merged
merged 1 commit into from
May 18, 2021
Merged

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 1fd64df0-a4d2-11e9-360d-2f03868f4cf5
Repo: https://github.com/JuliaMath/Xsum.jl.git
Tree: 00823085d988de32620d14b9524aa4bf7a708807

Registrator tree SHA: c7e033175c3b9b466fb2cc8beab47042878a66b0
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch May 17, 2021 22:33 Inactive
@github-actions
Copy link
Contributor

Your new version pull request met all of the guidelines for auto-merging and is scheduled to be merged in the next round.


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@giordano
Copy link
Member

giordano commented May 17, 2021

@stevengj since xsum_jll now requires julia v1.6 this should also require the same version, I think?

[noblock]

@stevengj
Copy link
Contributor

stevengj commented May 18, 2021

since xsum_jll now requires julia v1.6 this should also require the same version, I think?

Why? The Xsum.jl code per se doesn't require Julia 1.6, only one of its dependencies does.

[noblock]

@giordano
Copy link
Member

Because I think the package can't be effectively installed in Julia v1.5-. I'm going to let this pull request be merged, we can fix compat bounds afterwards if necessary.

[noblock]

@JuliaTagBot JuliaTagBot merged commit f84ff5a into master May 18, 2021
@JuliaTagBot JuliaTagBot deleted the registrator/xsum/1fd64df0/v1.2.0 branch May 18, 2021 09:30
@stevengj
Copy link
Contributor

If package A depends on package B, and package B requires Julia ≥ 1.x, should package A also explicitly list Julia ≥ 1.x in its Project.toml? Isn't taking the conjunction of the package requirements the responsibility of Pkg?

I guess the counter-argument is that if you can no longer test package A on Julia < 1.x, it is safer to require ≥ 1.x explicitly in A even if you think it would work for previous versions if not for B.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants