Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make authorization a guideline rather than early exit #553

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ericphanson
Copy link
Member

@ericphanson ericphanson commented Feb 3, 2024

As discussed on Slack, this is a step towards running AutoMerge on non-Registrator PRs. We also need to tweak the if on General to run AutoMerge on forks.

Note that we don't provision the merging token unless the PR is not from a fork, so we do have some additional security from that.

The guideline shoudl help give a clear error to explain why merging is not happening.

I put the guideline near the end so we still run all the other checks (it is after the last :update_status).

This PR does not address the fact that these PRs could be bad in ways we aren't testing for, bc we are counting on RegistryTools-based PRs. Quoting @GunnarFarneback on Slack:

The well-formedness of the PR tests could probably be sharpened. If there is no guarantee that the changes are created by RegistryTools, it should be verified that the given tree hash has the right name, uuid, version in the project file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant