Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Artifacts.toml #338

Merged
merged 4 commits into from
Aug 17, 2024
Merged

Conversation

amontoison
Copy link
Member

@amontoison amontoison commented Aug 15, 2024

Related to #337

  • Use the last release of the sifcollection added yesterday by Nick.
  • Add two new artifacts for LP and QP problems (netlib-lp and maros-meszaros).
  • Add an attribute lazy=true to only download an artifact if we need it.

For example, we should not download any artifact if the user defines the environment variable MASTSIF.

Note that the new standalone decoder available in SIFDecode_jll.jl and used since CUTEst_jll.jl v0.13.3 is tested on all these problems: ralna/SIFDecode#20
I tested it with single, double and quadruple precision.

We could update the function set_matsif to provide an option to switch between sifcollection, maros-meszaros and netlib-lp sets in a future PR.

@amontoison amontoison requested a review from tmigot August 15, 2024 22:28
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.29%. Comparing base (f2ad6a4) to head (c7c81bc).
Report is 17 commits behind head on main.

Files Patch % Lines
src/CUTEst.jl 90.90% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f2ad6a4) and HEAD (c7c81bc). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (f2ad6a4) HEAD (c7c81bc)
6 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #338       +/-   ##
===========================================
- Coverage   89.11%   62.29%   -26.83%     
===========================================
  Files           5        7        +2     
  Lines         790     1151      +361     
===========================================
+ Hits          704      717       +13     
- Misses         86      434      +348     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amontoison amontoison requested a review from tmigot August 16, 2024 20:37
@amontoison
Copy link
Member Author

@tmigot I added an optional argument to set_mastsif such that we can use another set of SIF problems.

Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still good for me

@amontoison amontoison merged commit 03f5228 into JuliaSmoothOptimizers:main Aug 17, 2024
10 of 13 checks passed
@amontoison amontoison deleted the artifacts branch August 17, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants