Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Aqua tests #459

Merged
merged 2 commits into from
May 17, 2024
Merged

Enable Aqua tests #459

merged 2 commits into from
May 17, 2024

Conversation

omus
Copy link
Member

@omus omus commented May 17, 2024

No description provided.

@omus omus merged commit be1f7c5 into master May 17, 2024
15 checks passed
@omus omus deleted the cv/aqua branch May 17, 2024 21:56
@ericphanson
Copy link
Contributor

ericphanson commented May 21, 2024

This seems to have broken pre-v1.9:

ERROR: LoadError: LoadError: ArgumentError: Package TimeZones does not have RecipesBase in its dependencies:
- If you have TimeZones checked out for development and have
  added RecipesBase as a dependency but haven't updated your primary
  environment's manifest file, try `Pkg.resolve()`.
- Otherwise you may need to report an issue with TimeZones

https://github.com/jump-dev/Convex.jl/actions/runs/9180785040/job/25247128212?pr=684

RecipeBase can't be removed, as the extension code is being conditionally included, meaning it must still be a direct dep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants