Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "Make IDE aware of generated code" documentation #168

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Update "Make IDE aware of generated code" documentation #168

merged 2 commits into from
Jan 17, 2023

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Jan 14, 2023

No description provided.

@twyatt twyatt requested review from a team and cedrickcooke as code owners January 14, 2023 03:45
@twyatt twyatt added the maintenance General maintenance that doesn't effect the public API. label Jan 14, 2023
@github-actions
Copy link

github-actions bot commented Jan 14, 2023 •
edited
Loading

Test Results

  5 files    5 suites   30s ⏱️
17 tests 17 ✔️ 0 💤 0 ❌
19 runs  19 ✔️ 0 💤 0 ❌

Results for commit 5ff526b.

♻️ This comment has been updated with latest results.

@ebabel
Copy link
Contributor

ebabel commented Jan 14, 2023 •
edited
Loading

After making this change I get this:
Could not resolve all files for configuration ':app:coreLibraryDesugaring'. Cannot resolve external dependency com.android.tools:desugar_jdk_libs:1.1.5 because no repositories are defined. Required by: project :app

I'll keep looking into it

@twyatt
Copy link
Member Author

twyatt commented Jan 14, 2023 •
edited
Loading

After making this change I get this: Could not resolve all files for configuration ':app:coreLibraryDesugaring'. Cannot resolve external dependency com.android.tools:desugar_jdk_libs:1.1.5 because no repositories are defined. Required by: project :app

I'll keep looking into it

Strange, perhaps try upgrading the desugar library?
We're using: com.android.tools:desugar_jdk_libs:2.0.0

@ebabel
Copy link
Contributor

ebabel commented Jan 16, 2023

Sorry, please disregard above, just an obvious flub on my part.

@twyatt twyatt merged commit f63b010 into main Jan 17, 2023
@twyatt twyatt deleted the twyatt/documentation branch January 17, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedrickcooke cedrickcooke cedrickcooke approved these changes

@davidtaylor-juul davidtaylor-juul davidtaylor-juul approved these changes

Assignees
No one assigned
Labels
maintenance General maintenance that doesn't effect the public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twyatt @ebabel @cedrickcooke @davidtaylor-juul