Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate function for creating Bundles w/o associated Intent or Fragment #31

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

cedrickcooke
Copy link
Collaborator

@cedrickcooke cedrickcooke commented Sep 28, 2020

Closes #30. Ended up going with bundleForXyz where Xyz is the simple name of your annotated class.

@cedrickcooke cedrickcooke requested review from a team, twyatt and QuantumRand September 28, 2020 00:17
@cedrickcooke
Copy link
Collaborator Author

The build failure is only uploading the snapshot. @twyatt that won't block this PR, but could you take a look (or tell me where to start) when you get a chance?

Copy link
Member

@twyatt twyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little outside my expertise, so apologies I can't offer more feedback than: LGTM! 😄

@twyatt
Copy link
Member

twyatt commented Sep 28, 2020

Once merged, #33 should unblock your CI build failures.

@cedrickcooke cedrickcooke merged commit b5b2040 into master Sep 28, 2020
@cedrickcooke cedrickcooke deleted the cedrickc/separate-bundle-generator branch September 28, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to generate Bundle without Intent or Fragment
3 participants