Final group capstone: Backend #23

K0ppai · 2023-11-02T14:41:31Z

Hello Reviewers,
We've worked on the following in this pull request,

The user logs in to the website by typing the email and password.
In the navigation panel, the user can see links to:
- "Yachts"
- "Reserve" form
- "My reservations"
- "Add Yacht"
- "Delete Yacht"
On the main page, the user can see a list of motorcycles/doctors/classes/items that you selected as a theme.
When the user selects a specific item, they can see the details page with its full description.
- In the details page, the user can click the "Reserve" button.
When the user clicks the "Add item" link in the navigation panel they can see a form for adding a new item.
Make the app responsive, creating both mobile and desktop versions.
When the user clicks the "Delete item" link in the navigation panel they can see a list of all items with title and "Delete" button.
- When the user clicks the "Delete" button, the selected item is marked as removed and does not show on the main list anymore.

To reserve an appointment, the user has to select a date and city.
- Use the design based on the "Book a vespa test-ride" and add all necessary inputs.
- The user can also access the "Reserve" page from the navigation panel.

When the user clicks the "My reservations" link in the navigation panel they can see a list of their reservations (with information about item name, date and city).
Add full documentation for API.

This the pull request for front end and API documentation.

If you're trying to run the app on local, kindly set up the following,

Generate a secret by typing this cmd: bundle exec rake secret in the terminal:
Run this cmd: EDITOR='code --wait' rails credentials:edit and once the encrypted .yml is opened
Copy this devise_jwt_secret_key: (copy and paste the generated secret here)
After copying the secret key in the encrypted .yml file, close it to save. For further information, kindly visit this link.

Thanks for the reviews. 😁

Set Up Rails Application

Create Authentication Features

Build a new item form

Yacht Rental Backend: Delete future

Yacht_Rental_Backend: Add Api Doc

Build reservation page

into develop

Deploy the website

into develop

Meltrust

Hi @K0ppai ,

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!

To highlight:

Nice code organization ✔️
API is working well✔️
Good readme ✔️

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

After implementing the requested changes, please submit another review request. ♻️

Check the comments under the review.

Cheers and Happy coding!👏👏👏

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.

Meltrust · 2023-11-02T16:02:21Z

README.md

+ EDITOR='code --wait' rails credentials:edit 
+``` 


In order for this command to work, you need to delete config/credentials.yml.enc first. Kindly, reflect this on your instructions.

Otherwise, it throws this error:

Meltrust · 2023-11-02T16:09:52Z

README.md

+  rspec ./spec/models
+```


This command won't work because there are no tests on that folder.

Meltrust · 2023-11-02T16:10:15Z

README.md

+  rake rswag:specs:swaggerize
+```


This command won't work because there are no tests on that folder.

Meltrust · 2023-11-02T16:38:24Z

config/initializers/cors.rb

+
+Rails.application.config.middleware.insert_before 0, Rack::Cors do
+  allow do
+    origins 'https://beta-yacht-rental.netlify.app' # later change to the domain of the frontend app


The local dev won't work because CORS will block it.

This is because the only origin that is being configured is the live demo frontend. Kindly, either reflect this on your instructions in case your users want to run local dev, or add the local origin that is missing. 👍

tip: This is an example about how to add multiple origins to cors:

Here is the full thread.

Meltrust

note: This review outcome only applies to the backend repo. Kindly, go to the frontend repo to see the review for that project.

Hi @K0ppai ,

Wow, you did it 🎉

Thank you for the changes implemented 💪 🥇 ㊗️

Unless you want to add more features, go ahead to your final presentation ⏩ ⏩ ⏩

You are about to finish the Microverse program. You have come a long way!!!

Good luck in the software industry!! I'll see you there. ✨

Congratulations!!!!!! 🎉

To highlight

Readme documentation has been vastly improved✔️

Cheers and Happy coding!👏👏👏

K0ppai and others added 30 commits October 25, 2023 20:48

Set up rails app

2d528a0

Set up devise and create user table

2c969aa

Create yachts,cities,yacht_cities and reservations table

5e8a78d

Update associations

768901e

Add database.yml file to gitignore

e043e29

Remove database.yml from Git tracking

cdb8095

Set up Linters for projects

c368bf2

Implement user model validation

bc9d204

Implement yacht model validation

a1cff1c

Implement city model validation

f971a70

Implement reservation model validation

3746e2c

Implement yact city model validation

14ea8ce

Fix rubocop errors

fa6d494

Merge pull request #13 from K0ppai/feature/create_db

1d898cc

Set Up Rails Application

Add jwt token column

bafa9d6

Set up devise and create authentication routes

cb206eb

Create registrations and sessions controller

513b935

Update application controller and user model for authentication

ef5a8d9

Merge pull request #14 from K0ppai/feature/setup_authentication

87fc8da

Create Authentication Features

Modifie the delete function from yacht controller

6868a3a

Modifie the yacht model so that it can be deleted

643b120

Add error json message in yacht controller

3db3003

Fix conflict errors

03bd5b4

Merge branch 'develop' into main-page-api-test

301df43

Update the rules

b73ee95

Fix linter errors

3141ef0

Fix linter errors

0c9d0db

Merge pull request #15 from K0ppai/feature/add_new_yacht

f35bd6d

Build a new item form

Merge pull request #16 from K0ppai/main-page-api-test

5d19a77

Yacht Rental Backend: Delete future

Update api for reservations

6793602

HtetWaiYan7191 and others added 23 commits November 1, 2023 15:24

Add api documentation using rswag gem

ceb203f

Fix linter errors

3c6f258

Merge pull request #20 from K0ppai/add-api-doc

7e5666e

Yacht_Rental_Backend: Add Api Doc

Update api for reservation page

f7c0b92

Add user_id in index action in reservation controller

277979b

Merge pull request #21 from K0ppai/feature/update_reservations_api

c1c88a7

Build reservation page

Update of README

aa68c30

Merge branch 'develop' of https://github.com/K0ppai/yacht-rental-backend

559f255

into develop

Add configuration for deploy

c64b72b

Try deploy attempt 1

572af2a

Try deploy attempt 2

b1aa339

Change routes in cors.rb

4b427ee

Add rails db:seed

f336523

Fix rubocop error

b0efe25

Fix rubocop error

c165289

Update of README adding demo link for frontend live

b8d045f

Update of README adding backend live demo link

56d6f94

Merge pull request #22 from K0ppai/beta_deploy

0a89aba

Deploy the website

Implement for client section of readme

80e32fc

Merge branch 'develop' of https://github.com/K0ppai/yacht-rental-backend

f0922e5

into develop

Update of readme file for the api documentation

0f251fd

Add ERD diagram in readme

c01cbef

Update of readme adding how to create credentails.yml.enc

c91d64e

Meltrust suggested changes Nov 2, 2023

View reviewed changes

Update of readme according to code reviewer request

d810d68

Meltrust approved these changes Nov 3, 2023

View reviewed changes

K0ppai added 2 commits November 6, 2023 15:35

Change origion in cors.rb

88312a5

Add Kanban Board in README.md

1479362

K0ppai merged commit 9271add into main Nov 8, 2023
2 checks passed

K0ppai temporarily deployed to yacht-rental January 23, 2024 07:36 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Final group capstone: Backend #23

Final group capstone: Backend #23

K0ppai commented Nov 2, 2023 •

edited

Loading

Meltrust left a comment •

edited

Loading

Meltrust Nov 2, 2023 •

edited by HtetWaiYan7191

Loading

Meltrust Nov 2, 2023

Meltrust Nov 2, 2023

Meltrust Nov 2, 2023 •

edited

Loading

Meltrust left a comment

Final group capstone: Backend #23

Final group capstone: Backend #23

Conversation

K0ppai commented Nov 2, 2023 • edited Loading

If you're trying to run the app on local, kindly set up the following,

Meltrust left a comment • edited Loading

Choose a reason for hiding this comment

To highlight:

You are really close to finishing the Microverse program!! Keep it up! 👍👍👍

After implementing the requested changes, please submit another review request. ♻️

Meltrust Nov 2, 2023 • edited by HtetWaiYan7191 Loading

Choose a reason for hiding this comment

Meltrust Nov 2, 2023

Choose a reason for hiding this comment

Meltrust Nov 2, 2023

Choose a reason for hiding this comment

Meltrust Nov 2, 2023 • edited Loading

Choose a reason for hiding this comment

Meltrust left a comment

Choose a reason for hiding this comment

Hi @K0ppai ,

Wow, you did it 🎉

Thank you for the changes implemented 💪 🥇 ㊗️

Unless you want to add more features, go ahead to your final presentation ⏩ ⏩ ⏩

You are about to finish the Microverse program. You have come a long way!!!

Good luck in the software industry!! I'll see you there. ✨

Congratulations!!!!!! 🎉

To highlight

K0ppai commented Nov 2, 2023 •

edited

Loading

Meltrust left a comment •

edited

Loading

Meltrust Nov 2, 2023 •

edited by HtetWaiYan7191

Loading

Meltrust Nov 2, 2023 •

edited

Loading