Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete katello-host-tools and katello-host-tools-fact-plugin packages when unregistering #222

Closed
alosadagrande opened this issue Sep 14, 2017 · 2 comments · Fixed by #226

Comments

@alosadagrande
Copy link
Contributor

Unregistering a client running katello-agent 3.0 does not delete katello-host-tools either katello-host-tools-fact-plugin.

This is causing issues when moving a client running katello-agent 3.0 to katello-agent 2.9. Actually katello-agent 2.9 is not installed due to error in dependencies.

@alosadagrande
Copy link
Contributor Author

Do you think we should check if katello-host-tools and/or katello-host-tools-fact-plugin are installed before calling yum erase on def clean_katello_agent():

call_yum("erase", "'katello-ca-consumer-' katello-agent gofer 'katello-host-tools' ")

@sideangleside
Copy link
Member

yum skips non-existing packages so there is no need to have any 'if/then' logic. This would also be consistent with other places where we remove packages (https://github.com/Katello/katello-client-bootstrap/blob/master/bootstrap.py#L418)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants