call rhn-migrate-classic-to-rhsm with --remove-rhn-packages #137
Conversation
There was a problem hiding this comment.
Not every version of rhn-migrate-classic-to-rhsm supports the --remove-rhn-packages option. see (https://bugzilla.redhat.com/show_bug.cgi?id=1185914) so I'd be a little uncomfortable calling it blindly.
We could either check for an appropriate version and call it only in that use case or stick with our function that removes packages. The upside of our function is that it works in all uses (migration and registration)
|
bah, you are right. we'd have to wrap that into if version... bah bah bah my idea was to keep both, as this allows us to benefit from the knowledge inside of migrate-to-rhsm |
|
It doesn't hurt to run both. I'm OK with this. |
|
Just so that I don't loose the link: https://bugzilla.redhat.com/show_bug.cgi?id=1185914 |
|
@evgeni this PR needs a rebase |
but only if we have removepkgs set (which is the default, though)
evgeni
force-pushed
the
add-remove-rhn-packages
branch
from
5e0f650
to
37db9b9
Compare
evgeni
force-pushed
the
add-remove-rhn-packages
branch
from
37db9b9
to
5dd5d1c
Compare
evgeni
force-pushed
the
add-remove-rhn-packages
branch
from
5dd5d1c
to
a86047b
Compare
* Bugfix for REX authorized_keys permission handling (Katello#298) * Improve error message and allow non-existing files for --rex-authpath (Katello#299) * Improve --rex-urlkeyfile help text (Katello#293) * Default bootstrap.py to install katello-host-tools and omit the katello-agent package (Katello#258) * Improve output when using the rex options (Katello#291) * Don't fail if yum clean fails (Katello#289) * Don't use json.loads to generate dicts (Katello#288) * Bugfix: don't build a newly created host (Katello#287) * Call rhn-migrate-classic-to-rhsm with --remove-rhn-packages (Katello#137) * Allow fetching REX keys from the API (Katello#282)
* Bugfix for REX authorized_keys permission handling (#298) * Improve error message and allow non-existing files for --rex-authpath (#299) * Improve --rex-urlkeyfile help text (#293) * Default bootstrap.py to install katello-host-tools and omit the katello-agent package (#258) * Improve output when using the rex options (#291) * Don't fail if yum clean fails (#289) * Don't use json.loads to generate dicts (#288) * Bugfix: don't build a newly created host (#287) * Call rhn-migrate-classic-to-rhsm with --remove-rhn-packages (#137) * Allow fetching REX keys from the API (#282)
but only if we have removepkgs set (which is the default, though)