Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow configuring timeout for API calls and subscription-manager #237

Merged
merged 1 commit into from
Jan 19, 2018

Conversation

sideangleside
Copy link
Member

@sideangleside sideangleside commented Jan 17, 2018

To make bootstrap.py more tolerant to busy Katello instances, this PR:

  • increases the urllib2 timeout for connections to 900 seconds / 15 minutes
  • Configures subscription-manager's server_timeout value to 900 seconds
  • provides the end user a new option -t or --timeout to change this timeout as per their requirements.

@mccun934
Copy link
Member

🥇 💯

Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only detail I don't like is the fact that we don't restore the old, original timeout setting for sub-man, but I can live with that.

@sideangleside
Copy link
Member Author

@evgeni On removal of the katello-ca-consumer package we run: test -f /etc/rhsm/rhsm.conf.kat-backup && command cp /etc/rhsm/rhsm.conf.kat-backup /etc/rhsm/rhsm.conf so if the user had a custom (or no) value set, it would be restored.

@evgeni evgeni merged commit 43c3982 into Katello:master Jan 19, 2018
evgeni added a commit to evgeni/katello-client-bootstrap that referenced this pull request Jan 23, 2018
* make bootstrap.py compatible with Puppet 4 (Katello#230)
* add ansible example playbook (Katello#197)
* remove SAMs CA consumer RPM in remove_obsolete_packages() (Katello#234)
* allow FIPS enabled systems to register successfully with puppet (Katello#236)
* allow configuring timeout for API calls and subscription-manager (Katello#237)
* implement switching proxy / caps without destroying the host in Foreman (Katello#227)
@evgeni evgeni mentioned this pull request Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants