Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tracer loading to always define the same method #150

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Dec 18, 2023

This now implements the pattern where it tries to define the collect_apps method and simply use that, without additional variables.

Copy link
Member

@sbernhard sbernhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@ianballou
Copy link
Member

@ekohl should this have a redmine? Maybe referring to https://projects.theforeman.org/issues/36973 ?

Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is looking fine to me! Just wondering about the redmine.

This now implements the pattern where it tries to define the
collect_apps method and simply use that, without additional variables.
@ianballou ianballou merged commit f494bb9 into Katello:master Mar 1, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants