Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof caching: external database #3265

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

FliegendeWurst
Copy link
Member

@FliegendeWurst FliegendeWurst commented Aug 28, 2023

This PR expands the proof caching infrastructure by introducing an external database of proofs.

Proofs are currently added manually by the user to the database.
The user may inspect the database in a dialog.

TODO:

  • automatically add proofs to the database once they're closed (activated by an option)
  • automatically search in the external database during proof search
  • allow the user to remove proofs from the database in the UI
  • fix Java proof caching

@FliegendeWurst FliegendeWurst added GUI Feature New feature or request labels Aug 29, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Attention: Patch coverage is 1.73661% with 679 lines in your changes are missing coverage. Please review.

Project coverage is 37.66%. Comparing base (cde763f) to head (f540a14).

❗ Current head f540a14 differs from pull request most recent head d61ed21. Consider uploading reports for the commit d61ed21 to get more accurate results

Files Patch % Lines
.../gui/plugins/caching/database/CachingDatabase.java 0.00% 277 Missing ⚠️
...lugins/caching/database/CachingDatabaseDialog.java 0.00% 78 Missing ⚠️
...lkd/key/gui/plugins/caching/CachedProofBranch.java 0.00% 67 Missing ⚠️
...ins/caching/actions/RealizeFromDatabaseAction.java 0.00% 32 Missing ⚠️
...plugins/caching/database/CachingDatabaseTable.java 0.00% 29 Missing ⚠️
...ilkd/key/gui/plugins/caching/CachingExtension.java 0.00% 25 Missing ⚠️
...org/key_project/slicing/graph/DependencyGraph.java 0.00% 19 Missing ⚠️
...key/gui/plugins/caching/TypeCollectingVisitor.java 0.00% 18 Missing ⚠️
...ey/gui/plugins/caching/SearchInDatabaseAction.java 0.00% 17 Missing ⚠️
.../plugins/caching/database/AutoAddClosedProofs.java 0.00% 17 Missing ⚠️
... and 21 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3265      +/-   ##
============================================
- Coverage     37.88%   37.66%   -0.22%     
+ Complexity    17082    17044      -38     
============================================
  Files          2090     2093       +3     
  Lines        127485   127958     +473     
  Branches      21466    21521      +55     
============================================
- Hits          48294    48192     -102     
- Misses        73285    73852     +567     
- Partials       5906     5914       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant