Removal of Triple, and Quadruple #3399
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...execution/src/main/java/de/uka/ilkd/key/symbolic_execution/SymbolicExecutionTreeBuilder.java
Outdated
Show resolved
Hide resolved
wadoon
force-pushed
the
weigl/recordsftw
branch
from
65fd13c
to
06e30f8
Compare
wadoon
force-pushed
the
weigl/recordsftw
branch
from
06e30f8
to
423c10b
Compare
wadoon
changed the title
wadoon
force-pushed
the
weigl/recordsftw
branch
from
423c10b
to
c691c0b
Compare
wadoon
added
the
🛠 Maintenance
wadoon
force-pushed
the
weigl/recordsftw
branch
from
c691c0b
to
4545251
Compare
* main: (77 commits) Update key.core/src/main/java/de/uka/ilkd/key/nparser/builder/TacletPBuilder.java spotless update oracle for taclet equality test change gradle github action to new syntax adding comments to jml spec factory default contracts repair soundness of assignment2UpdateRules with checked overflows spotless EQ version of seqSwapPreservesSeqPerm + proof added rule for sequences: swap preserves perm Changed types in replacement map for WD taclets, since PR KeYProject#3436 made casting TermSV to ProgramVariable not applicable spotlessing ... making RuleCommand work if already fully instantiated RuleCommand can now deal with rules that have schema variables for logical variables. Fix loading of taclet proof obligations (issue KeYProject#3477) * This commit fixes an NPE when loading * This commit fixes missing or inconsistent selection of loaded proof obligation Code clean up (remove unused method) Fix loading of closed proofs (GUI threw error) Fix and test goToNext() Fix goToNextSibling() (thx Tobias) Format Add comments and next() method ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring
This PR starts the removal of generic data classes in favor of Java records (aka. named tuples). In this PR, only
TripleandQuadrupleare removed.In general, generic parametric data classes (
Tuple,Union, ...) lead to unreadable, incomprehensible code, e.g., what does the entityTriple<StatementBlock, URI, Integer>express? Answer: It is the key in a map to find block contracts. Using the recordBlockContractKeyexpresses this better than triple of something.Therefore, records give you the chance of defining useful variable names, and documentation, and also avoid auto-boxing (hence NPE).
Intended Change
No use of
Triple<…>andQuadruple<…>.Type of pull request
Ensuring quality