Fix D3D12 error for 'Grip and Aim pose' and other tests #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I have no experience to review this, perhaps ask in the chat. Can you add a changelog fragment? |
rpavlik
added a commit
that referenced
this pull request
Nov 16, 2020
- Registry
- All changes found in 1.0.10, 1.0.11, and 1.0.12.
- Conformance Tests
- Fix: Fix Vulkan image layout transitions (internal MR 1876)
- Fix: Images were being copied upside-down in OpenGL ES.
(internal MR 1899)
- Fix: Issues around xrInitializeLoaderKHR. (internal MR 1922)
- Fix: Fix some interactive tests like “Grip and Aim Pose” which
exposed D3D12 validation errors due to bugs in the D3D12
graphics plugin. (OpenXR-CTS/#1)
- Fix: Use REQUIRE macro in main thread only, in
Timed Pipelined Frame Submission to prevent race condition.
(OpenXR-CTS/#2)
- Improvement: Enable use of glslangValidator to compile shaders
if shaderc is not available. (internal MR 1857)
- Improvement: Add options to not run tests that require
disconnecting devices. (internal MR 1862)
- Improvement: xrStructureTypeToString, xrResultToString: Make
test more lenient, so it will also accept the “generic”
generated value for enumerant values defined by an extension
that is not currently enabled. (internal MR 1864)
- Improvement: Improve language usage in code and comments to be
more respectful. (internal MR 1881)
- Improvement: Handle the new
XR_ERROR_GRAPHICS_REQUIREMENTS_CALL_MISSING return code, and
move all checks for this code to the xrCreateSession test, from
the individual graphics bindings tests. (internal MR 1882,
OpenXR-Docs/#53, internal issue 1397)
- Improvement: Automatically enable a number of extensions, if
present, that can be enabled without side-effects. (internal MR
1897)
- Improvement: Use the XR_KHR_loader_init_android extension on
Android instead of vendor-specific code. (internal MR 1903)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the conformance tests do not work when use when using D3D12 with D3D12 command allocator erroring. These fixes were made by @gongminmin.