Changes to make some kinds of layer comp flag failures more obvious #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The background alpha is on the green layers and the example quad are 0 now. Those quad layers don't include the "use texture alpha" flag, so they should draw in exactly the same way. If the implementation is actually using the alpha from the texture, they will be invisible, which will be obviously wrong in the output. Added the "not premult" flag to those quads too. SteamVR doesn't currently pay any attention to the "use alpha" flag, but it does monitor the premult flag. A fully conformant runtime should ignore the premult flag if the other one isn't set too, so this should not affect those.
|
An issue (number 1553) has been filed to correspond to this issue in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#1553 ), to facilitate working group processes. This GitHub issue will continue to be the main site of discussion. |
brycehutchings
approved these changes
Apr 8, 2021
Wallbraker
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The background alpha is on the green layers and the example quad are 0 now. Those quad layers don't include the "use texture alpha" flag, so they should draw in exactly the same way. If the implementation is actually using the alpha from the texture, they will be invisible, which will be obviously wrong in the output.
Added the "not premult" flag to those quads too. SteamVR doesn't currently pay any attention to the "use alpha" flag, but it does monitor the premult flag. A fully conformant runtime should ignore the premult flag if the other one isn't set too, so this should not affect those.