Initial conformance tests for WEBGL_shader_pixel_local_storage #3530

csmartdalton · 2023-03-17T03:34:30Z

Creates a set of tests that verify the non-normative WebGL behavior, as well as providing some scaffolding to verify the ANGLE extension is properly hooked up.

If these all look good, we can start porting tests from the ANGLE extension next.

csmartdalton · 2023-03-17T03:36:10Z

@kenrussell @lexaknyazev please take a look.

Ken, this collides with your previous PR. I can rebase after you land.

I think this, combined with the ANGLE tests, ought to be enough coverage to land a draft implementation in Chrome!

csmartdalton · 2023-03-17T07:00:51Z

Done

csmartdalton · 2023-03-17T07:02:43Z

Closed by accident.

This is rebased and ready for review.

lexaknyazev

Please add a test that asserts correct PLS behavior on page composition (wtu.waitForComposite) events without an app explicitly ending PLS. It should include app-observable state of indexed color masks (if they could be implicitly changed) and implicit clears of the default FBO.

sdk/tests/conformance2/extensions/webgl-shader-pixel-local-storage.html

extensions/WEBGL_shader_pixel_local_storage/extension.xml

kenrussell

Great work Chris on these tests! A few small revisions requested.

extensions/WEBGL_shader_pixel_local_storage/extension.xml

sdk/tests/conformance2/extensions/webgl-shader-pixel-local-storage.html

csmartdalton

Please add a test that asserts correct PLS behavior on page composition (wtu.waitForComposite) events without an app explicitly ending PLS.

This is done, but commented for now because it breaks Chrome. Good test idea!

It should include app-observable state of indexed color masks (if they could be implicitly changed) and implicit clears of the default FBO.

ANGLE has a comprehensive test for indexed color mask. I think I can bring in all of the ANGLE validation tests with this PR. Did you have anything more specific in mind?

sdk/tests/conformance2/extensions/webgl-shader-pixel-local-storage.html

extensions/WEBGL_shader_pixel_local_storage/extension.xml

sdk/tests/conformance2/extensions/webgl-shader-pixel-local-storage.html

lexaknyazev · 2023-03-18T22:38:23Z

ANGLE has a comprehensive test for indexed color mask. I think I can bring in all of the ANGLE validation tests with this PR. Did you have anything more specific in mind?

Browsers may change color masks to enable all channels while doing an implicit clear; alpha mask may be forced to be false for contexts created with opaque default framebuffer (via WebGLContextAttributes).

The test should ensure that browser's and PLS' implicit color mask updates work correctly together and the last user-set state is restored.

csmartdalton · 2023-03-20T19:01:35Z

The test should ensure that browser's and PLS' implicit color mask updates work correctly together and the last user-set state is restored.

Got it, thanks!

https://chromium-review.googlesource.com/c/angle/angle/+/4355032 would enable us to easily handle the clear after compositing when thte app leaves PLS enabled. Do you think these spec changes look OK?

sdk/tests/conformance2/extensions/webgl-shader-pixel-local-storage.html

csmartdalton

I had some local changes I had forgotten to commit before I did my last update 🤦.

Let's hold off until I finish building Chrome and can verify these tests are all correct and passing, but I think we should be just about ready.

csmartdalton · 2023-03-29T17:29:16Z

I think all the comments are addressed now, and these tests are passing locally for me in Chrome.

@kenrussell and @lexaknyazev, does this change look ready to land now?

lexaknyazev · 2023-03-29T17:54:46Z

sdk/tests/conformance2/extensions/webgl-shader-pixel-local-storage.html

+
+const wtu = WebGLTestUtils;
+const canvas = document.getElementById("canvas");
+const gl = wtu.create3DContext(canvas, {alpha: false}, 2);


Could the rendering test be repeated for the default (alpha: true) case? No-alpha composition may use different code paths.

Would you just create two different canvases on the page? Or use an offscreen canvas for one of them?

Create a regular canvas from JS, get an alpha-enabled context, run tests, delete that canvas, repeat with alpha disabled.

It's a good idea to check PLS operations with OffscreenCanvas but it would better be a separate test.

Done! Can't quite delete it yet though because it needs to go to sleep for compositing.

This test also captures PLS being active on two contexts at once.

OffscreenCanvas might be a good candidate for some of the future tests I can import from ANGLE.

Does this look good to land now?

kenrussell

Thanks for revising this Chris. It looks like there were a couple of small mistakes in the extension.xml. Did you try running "make" in your extensions/ directory locally?

extensions/WEBGL_shader_pixel_local_storage/extension.xml

Creates a set of tests to check the WebGL behavior not found in the ANGLE_shader_pixel_local_storage specification, as well as providing some scaffolding to verify the ANGLE extension is properly hooked up. If these all look good, we can start porting tests from the ANGLE extension next.

csmartdalton · 2023-05-19T02:37:31Z

Thanks for revising this Chris. It looks like there were a couple of small mistakes in the extension.xml. Did you try running "make" in your extensions/ directory locally?

I think this should all be good now. I ran make locally and checked that the output reflected the most recent edits.

kenrussell

Thanks for the updates - looks good!

Await the results of asynchronous functions, and explicitly call finishTest() at the end of runTest(). Follow-on to KhronosGroup#3530 .

Await the results of asynchronous functions, and explicitly call finishTest() at the end of runTest(). Follow-on to #3530 .

Timeouts were accidentally introduced in the last commit by failing to do this. Follow-on to KhronosGroup#3562 and KhronosGroup#3530.

@lexaknyazev

* Call finishTest() when PLS isn't supported. Timeouts were accidentally introduced in the last commit by failing to do this. Follow-on to #3562 and #3530. Fixed bugs caught by @lexaknyazev in code review.

csmartdalton force-pushed the plstests branch from 13360ce to 13531ea Compare March 17, 2023 06:58

csmartdalton closed this Mar 17, 2023

csmartdalton reopened this Mar 17, 2023

lexaknyazev reviewed Mar 17, 2023

View reviewed changes

sdk/tests/conformance2/extensions/webgl-shader-pixel-local-storage.html Outdated Show resolved Hide resolved

extensions/WEBGL_shader_pixel_local_storage/extension.xml Show resolved Hide resolved

kenrussell requested changes Mar 17, 2023

View reviewed changes

csmartdalton force-pushed the plstests branch from 13531ea to ea5653d Compare March 18, 2023 20:23

csmartdalton commented Mar 18, 2023

View reviewed changes

kenrussell requested changes Mar 21, 2023

View reviewed changes

csmartdalton force-pushed the plstests branch from ea5653d to 307ea25 Compare March 21, 2023 16:41

csmartdalton commented Mar 21, 2023

View reviewed changes

csmartdalton force-pushed the plstests branch from 307ea25 to 3fd8531 Compare March 21, 2023 16:52

csmartdalton force-pushed the plstests branch from 3fd8531 to 0f453b9 Compare March 29, 2023 17:23

lexaknyazev reviewed Mar 29, 2023

View reviewed changes

csmartdalton force-pushed the plstests branch 4 times, most recently from 273b022 to 7f89fc4 Compare March 30, 2023 06:58

kenrussell requested changes May 15, 2023

View reviewed changes

extensions/WEBGL_shader_pixel_local_storage/extension.xml Show resolved Hide resolved

extensions/WEBGL_shader_pixel_local_storage/extension.xml Show resolved Hide resolved

csmartdalton force-pushed the plstests branch from 7f89fc4 to 2450798 Compare May 18, 2023 18:52

kenrussell approved these changes May 19, 2023

View reviewed changes

kenrussell merged commit b934957 into KhronosGroup:main May 19, 2023

kenrussell added a commit to kenrussell/WebGL that referenced this pull request Jul 6, 2023

Fix async portions of PLS test.

a10a97a

Await the results of asynchronous functions, and explicitly call finishTest() at the end of runTest(). Follow-on to KhronosGroup#3530 .

kenrussell mentioned this pull request Jul 6, 2023

Fix async portions of PLS test. #3562

Merged

kenrussell added a commit that referenced this pull request Jul 6, 2023

Fix async portions of PLS test. (#3562)

795e62c

Await the results of asynchronous functions, and explicitly call finishTest() at the end of runTest(). Follow-on to #3530 .

kenrussell added a commit to kenrussell/WebGL that referenced this pull request Jul 6, 2023

Call finishTest() when PLS isn't supported.

fafdcf8

Timeouts were accidentally introduced in the last commit by failing to do this. Follow-on to KhronosGroup#3562 and KhronosGroup#3530.

kenrussell mentioned this pull request Jul 6, 2023

Call finishTest() when PLS isn't supported. #3563

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial conformance tests for WEBGL_shader_pixel_local_storage #3530

Initial conformance tests for WEBGL_shader_pixel_local_storage #3530

csmartdalton commented Mar 17, 2023

csmartdalton commented Mar 17, 2023

csmartdalton commented Mar 17, 2023

csmartdalton commented Mar 17, 2023

lexaknyazev left a comment

kenrussell left a comment

csmartdalton left a comment

lexaknyazev commented Mar 18, 2023

csmartdalton commented Mar 20, 2023

csmartdalton left a comment

csmartdalton commented Mar 29, 2023

lexaknyazev Mar 29, 2023 •

edited

Loading

csmartdalton Mar 29, 2023

lexaknyazev Mar 29, 2023

csmartdalton Mar 30, 2023

kenrussell left a comment

csmartdalton commented May 19, 2023

kenrussell left a comment

Initial conformance tests for WEBGL_shader_pixel_local_storage #3530

Initial conformance tests for WEBGL_shader_pixel_local_storage #3530

Conversation

csmartdalton commented Mar 17, 2023

csmartdalton commented Mar 17, 2023

csmartdalton commented Mar 17, 2023

csmartdalton commented Mar 17, 2023

lexaknyazev left a comment

Choose a reason for hiding this comment

kenrussell left a comment

Choose a reason for hiding this comment

csmartdalton left a comment

Choose a reason for hiding this comment

lexaknyazev commented Mar 18, 2023

csmartdalton commented Mar 20, 2023

csmartdalton left a comment

Choose a reason for hiding this comment

csmartdalton commented Mar 29, 2023

lexaknyazev Mar 29, 2023 • edited Loading

Choose a reason for hiding this comment

csmartdalton Mar 29, 2023

Choose a reason for hiding this comment

lexaknyazev Mar 29, 2023

Choose a reason for hiding this comment

csmartdalton Mar 30, 2023

Choose a reason for hiding this comment

kenrussell left a comment

Choose a reason for hiding this comment

csmartdalton commented May 19, 2023

kenrussell left a comment

Choose a reason for hiding this comment

lexaknyazev Mar 29, 2023 •

edited

Loading