We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug When importing a spot light that does not contain an outerConeAngle, import fails on the create_spot method.
Assumed issue is
glTF-Blender-IO/addons/io_scene_gltf2/blender/imp/light.py
Line 118 in 295bbf7
To Reproduce
Expected behavior Import should succeed as normal, using the default value of PI/4.0 for outerConeAngle as defined in the KHR_lights_punctual
Sample
{ "extensions": { "KHR_lights_punctual": { "lights": [ { "spot": { "innerConeAngle": 0.10000000149011612 }, "type": "spot" } ] } }, "asset": { "copyright": "", "generator": "SharpGLTF 1.0.0\u002Bf5cd805711f76596a77a71de9cba4717e0edd159", "version": "2.0" }, "extensionsUsed": [ "KHR_lights_punctual" ], "nodes": [ { "extensions": { "KHR_lights_punctual": { "light": 0 } } } ], "scene": 0, "scenes": [ { "nodes": [ 0 ] } ] }
Version
The text was updated successfully, but these errors were encountered:
Confirmed
Sorry, something went wrong.
532ae57
Merge pull request #2350 from KhronosGroup/fix_2349_spot_default
5fbd6a3
Fix #2349 - spot default gltf values
Successfully merging a pull request may close this issue.
Describe the bug
When importing a spot light that does not contain an outerConeAngle, import fails on the create_spot method.
Assumed issue is
glTF-Blender-IO/addons/io_scene_gltf2/blender/imp/light.py
Line 118 in 295bbf7
When calling calc_spot_cone_inner, the value for outerConeAngle may not exist
To Reproduce
Expected behavior
Import should succeed as normal, using the default value of PI/4.0 for outerConeAngle as defined in the KHR_lights_punctual
Sample
Version
The text was updated successfully, but these errors were encountered: