Fix web components as openers/closers not working properly #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KittyGiraudel
commented
Sep 5, 2024
| }, | ||
| } | ||
|
|
||
| cy.spy(handlers, 'show').as('show') | ||
| cy.spy(handlers, 'hide').as('hide') | ||
| cy.window().its('instance').invoke('on', 'show', handlers.show) | ||
| cy.window().its('instance').invoke('on', 'hide', handlers.hide) | ||
| cy.get('my-dialog').shadow().find('fancy-button').first().click() |
There was a problem hiding this comment.
The tests were passing because .click() was clicking the exact shadow root. A .realClick() however would click the inner <slot> and cause the test to fail, as reported in #712.
KittyGiraudel
commented
Sep 5, 2024
| ) { | ||
| this.hide(event) | ||
| } | ||
| const opener = closest(`[${SCOPE}-show="${this.id}"]`, target) |
There was a problem hiding this comment.
The code was massaged a bit to be easier to read but the fix is the use of closest(..).
KittyGiraudel
commented
Sep 5, 2024
Comment on lines
+203
to
+205
| // we use our custom `closest(..)` function so that it can cross shadow | ||
| // boundaries | ||
| // See: https://github.com/KittyGiraudel/a11y-dialog/issues/712 |
There was a problem hiding this comment.
This is the actual fix explanation.
ella-etch
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #712.