Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move showcoveragegraph.php AJAX endpoint to controller #1521

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Move showcoveragegraph.php AJAX endpoint to controller #1521

merged 1 commit into from
Jun 28, 2023

Conversation

williamjallen
Copy link
Collaborator

This PR is part of an ongoing series of refactor PRs with the goal of migrating all of the /ajax/* routes to Laravel's routing/controller scheme.

josephsnyder
josephsnyder approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned IRL, the display itself might be broken but the response from both this and the original ajax end point are the same. Approved.

@williamjallen williamjallen added this pull request to the merge queue Jun 28, 2023
Merged via the queue into Kitware:master with commit 8e39fe0 Jun 28, 2023
1 check passed
@williamjallen williamjallen deleted the ajax-coverage-graph branch June 28, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephsnyder josephsnyder josephsnyder approved these changes

Assignees
No one assigned
Labels
release notes: maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williamjallen @josephsnyder