-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert backend of SubProject
model to Eloquent
#1695
Merged
williamjallen
merged 1 commit into
Kitware:master
from
williamjallen:subproject-eloquent-model
Sep 8, 2023
Merged
Convert backend of SubProject
model to Eloquent
#1695
williamjallen
merged 1 commit into
Kitware:master
from
williamjallen:subproject-eloquent-model
Sep 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsnyder
approved these changes
Sep 8, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sep 8, 2023
@williamjallen, looks like it could use a rebase when you have the time: Merge queue failed due to phpstan:
|
williamjallen
force-pushed
the
subproject-eloquent-model
branch
from
September 8, 2023 14:40
ea5b7ec
to
df57265
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
#1695 created an Eloquent-based `SubProject` model, but did not attempt to change existing usages of the legacy model. This is a small follow-up PR which expands the usage of the project-subproject relationship to gain access to subprojects through the eloquent-based project model. Amongst other things, this change should make a few pages slightly faster by reducing the number of database queries executed when iterating over subprojects. This PR also unifies the logic for determining which subprojects were active on a given date. It is probable that the prior inconsistent logic caused unexpected behavior in rare cases. I intend to work on subproject <-> build relationships in a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of our ongoing effort to switch all of our models to Laravel's Eloquent ORM library. The legacy
SubProject
model has been turned into an adapter for the Eloquent-based model, using the same approach taken in #1556.