Fix subproject dependency graph rendering #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior
Currently, when loading the SubProject Dependencies page for a given project, depending on the number of subprojects and the length of their names, the rendering of the graph may overlap the text on the page.
Additionally, when hovering on top of nodes in the graph, the following error is printed to the console:
New behavior
The graph will never overlap the text on the page anymore, and it set to be rendered on the center of the page. The console error is fixed and the tooltip now displays properly (the tiny white triangle connected to the textbox that pops up on hover).