Migrate the monitor page plot to d3 #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update tooltip text using Vue refs (and refactor its style) * follow Vue convention for prop name casing * use Array.forEach function on Monitor page instead of manual for loop
williamjallen
requested changes
Dec 6, 2023
williamjallen
approved these changes
Dec 10, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 10, 2023
According to [the PHPUnit docs for `assertEquals()`](https://docs.phpunit.de/en/9.6/assertions.html#assertequals), the first argument to the function should be the expected output, and the second argument should be the actual value as produced by the test. Currently, we have multiple places in the codebase where this ordering of the arguments is not respected. Calling this function with the arguments swapped can lead to confusion when debugging failed tests, as PHPUnit's error messages present failed comparisons in terms of an "expected" and an "actual" value. The changes in this PR correct the instances where we use the wrong ordering (except for the file `tests/Feature/Monitor.php` which is being improved in PR #1826). There are many other PHPUnit assertion functions that follow this argument format and are used in our test suites. Future PRs will correct the cases for those functions where the argument ordering is not respected as well. It would also be nice if we could add tools to automatically enforce this, in order to prevent this from happening in the future and improve our development experience.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
#1875 resolved the eslint errors which were blocking this PR, so this should be ready to merge. |
This was referenced Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a d3 template for plotting line graphs of time-series datasets, and converts the monitor page plot from nvd3 to the new template. This change marks the first step of our efforts to migrate to a single plotting/visualization dependency (see #1744). As we migrate more pages to Vue in the future, other plots across the site will also be able to use the new template and expand upon it.
TODO: finalize style and appearance of plot