Refactor manageOverview.php API endpoint
#1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsnyder
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
LGTM. One small issue with saving a layout with no groups at all, but I don't imagine that's going to happen too often.
I've created an issue (#1889) for it and we can decide if it should be made a part of this change or a future update.
|
I'll make the changes in this PR. |
josephsnyder
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues our ongoing effort to migrate our legacy API to Laravel controllers, and to convert our protractor tests to Cypress. Supersedes #1666. I also made Cypress query the value of APP_URL each time a test is run in case the value changes from one test to another. This PR also fixes #1889.