Add Font Awesome free icons #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbelsk
reviewed
Dec 18, 2023
|
I think it's better to leave the images until #1851 gets merged. Removing them will cause conflicts, and I don't want to accidentally delete something I shouldn't while fixing merge conflicts. I'll do another pass through the images to look for unused images at a future point. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 4, 2024
We currently provide no information about the state of the page for pages with API endpoints which take a long time to return. This PR adds a Vue template which accepts a slot for content to be rendered when the page is loaded, and a boolean prop which indicates whether the loading indicator should be shown. I have initially used this template to add loading indicators to two pages as an example for future use. I plan to switch the loading indicator icon to a Font Awesome icon instead of a grainy GIF once #1895 is merged.
sbelsk
approved these changes
Jan 7, 2024
williamjallen
force-pushed
the
font-awesome-icons
branch
from
36bd9b2
to
6c1f173
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the icons throughout the CDash UI are low resolution PNGs. User expectations have changed since those icons were introduced, and pixelated icons are no longer considered acceptable, given that most users have high-resolution screens. Font Awesome is a well known icon provider which provides a vast number of free SVG icons.
I've opened this PR up to get some feedback. As an initial demonstration, I have changed the action buttons on the user homepage to font awesome icons. CDash is in dire need of a substantial UI overhaul, and I'm by no means a UI/UX designer, so I'm open to any feedback anyone might have about the specific icons I've chosen, as well as general feedback about this idea as a whole.