Pluralize index routes #1900
Merged
Pluralize index routes #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
This change fixes to a typo in the pluralization rerouting logic (introduced in #1900) that broke all existing references to the url: `build/<buildid>/configure`.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 28, 2024
This PR adds a new Cypress end-to-end test for the `builds/<buildid>/configure` page, as part of our efforts to increase the test coverage. The changes also include a fix to a typo in the pluralization rerouting logic (introduced in #1900) that broke all existing references to the url: `build/<buildid>/configure`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is traditional for "index" routes which display a list of subitems which can be navigated to via unique IDs to be pluralized. For example, a page showing the questions available should be under the route
/questions, while a specific question should be available at/questions/<id>. Examples of major websites which follow this convention:CDash currently has an inconsistent mix of route styles. As we work to modernize the codebase, we should also modernize our routing structure while maintaining backwards compatibility wherever possible.
This PR standardizes the plurality of our routes which do not end with
.php. Updating every link across the site is a major undertaking, and I plan to gradually update links as I refactor various pages as part of CDash 3.4.