Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Protractor+Selenium testing logic #1978

Merged
merged 2 commits into from
Jan 28, 2024

Conversation

williamjallen
Copy link
Collaborator

Thanks to @sbelsk's work to convert our Protractor tests to Cypress, Protractor is no longer needed. I deleted all of the broken Selenium testing suite at the same time. The one remaining Protractor test I deleted in this PR is a duplicate of one of the tests @sbelsk converted.

Copy link
Collaborator

@sbelsk sbelsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the tests still seem to pass. Thanks!

@williamjallen williamjallen added this pull request to the merge queue Jan 28, 2024
Merged via the queue into Kitware:master with commit 0d83867 Jan 28, 2024
2 checks passed
@williamjallen williamjallen deleted the remove-protractor branch January 28, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants