Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HTTP 500 error for testOverview + filters timeline (backport to 3.2) #2022

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Fix HTTP 500 error for testOverview + filters timeline (backport to 3.2) #2022

merged 3 commits into from
Feb 9, 2024

Commits on Feb 9, 2024

  1. Remove use of $this->FilterSQL from Timeline API 

    Attempting to insert filterdata SQL into the timeline queries would
result in HTTP 500 errors when they referenced tables not joined into
the main query.

For now, remove this optional, extra SQL from our timeline queries,
and plan to revisit this functionality later, possibly using GraphQL.
    @zackgalbreath
    zackgalbreath committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    d2aa465 View commit details
    Browse the repository at this point in the history

  2. Remove unused chartForIndex() function 

    There is currently no code path or public route to trigger this
functionality.
    @zackgalbreath
    zackgalbreath committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    20c9faa View commit details
    Browse the repository at this point in the history

  3. Regenerate phpstan-baseline.neon

    @zackgalbreath
    zackgalbreath committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    fdaeff9 View commit details
    Browse the repository at this point in the history