Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule periodic tasks with Laravel #2222

Merged
merged 3 commits into from
May 30, 2024

Conversation

williamjallen
Copy link
Collaborator

@williamjallen williamjallen commented May 27, 2024

NOTE: This PR moves cleanup logic out of the request-triggered daily update script. To continue having these cleanup tasks performed automatically, administrators of non-Docker systems must run php artisan schedule:run via cron or similar.

The current "daily update" process is clunky, and in dire need of a refactor. This PR takes the first step towards modernizing the daily update process by separating out a few small portions of the process into independent "tasks" managed by Laravel. This PR also develops the infrastructure needed to eventually perform LDAP syncing for #1983.

Laravel overhauled the task system in Laravel 11, but we can't upgrade to Laravel 11 until Red Hat releases a UBI image with PHP 8.2+.

@williamjallen
Copy link
Collaborator Author

@zackgalbreath FYI: this will require manual changes to bare metal installations.

@williamjallen williamjallen added this to the v3.5 milestone May 27, 2024
Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generation of the tasks looks good. My Docker instance's schedule:work can run the tasks without issue so I think things are in good shape!

@josephsnyder josephsnyder added this pull request to the merge queue May 30, 2024
Merged via the queue into Kitware:master with commit d1bf379 May 30, 2024
6 checks passed
@williamjallen williamjallen deleted the scheduled-jobs branch May 31, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants