Remove Docker health check #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
no-curl-healthcheck
branch
2 times, most recently
from
0068475
to
c956a10
Compare
williamjallen
force-pushed
the
no-curl-healthcheck
branch
from
89ee2d0
to
df182c9
Compare
zackgalbreath
approved these changes
Jul 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The health check built into our Docker image has caused significant problems across a variety of different system configurations. The health check is rather rudimentary and its effectiveness is limited, especially given that CDash can accept submissions without a working database connection.
This PR simply removes the health check altogether, in favor of client-specific implementations if a health check is desired.