RepositoryUtils: fix GitLab URL generation #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be a great thing to include in CDash 3.5. Can you please change the base branch to |
mathstuf
force-pushed
the
gitlab-diff-url-fix
branch
from
e43a8f8
to
8974247
Compare
GitLab started using a `/-/` component to act as a separator between project paths and project resources. Also fold the old factored-out function back into the Gitorious implementation. Also make the static analysis happy with stricter comparisons.
mathstuf
force-pushed
the
gitlab-diff-url-fix
branch
from
8974247
to
0269eea
Compare
williamjallen
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitLab started using a
/-/component to act as a separator between project paths and project resources.