Use filter-based approach for LDAP project membership #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackgalbreath
approved these changes
Aug 23, 2024
williamjallen
force-pushed
the
project-ldap-filter-updates
branch
from
93c0789
to
62b6e6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to user feedback about the new LDAP-based project membership feature added in #2282, this PR changes the project LDAP field to accept a filter instead of a group name for consistency with our existing
LDAP_FILTERS_ONenvironment variable.This PR also addresses an issue with
LDAP_FILTERS_ONrelated to the switch from Adldap2 in #2206 and reverts the environment variable rename fromLDAP_HOSTStoLDAP_HOSTto maintain backwards compatibility with existing systems.