-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grouping for LEDs for use as separate chain on a single gpio #6446
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Brochard Pierre <elenedeath@gmail.com>
Signed-off-by: Brochard Pierre <elenedeath@gmail.com>
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
Thank you for picking this up again and fixing the issue of the original PR. I would really like this feature to be merged to Klipper. I am completely fine with reusing the code from the original PR for this one. Let me know if I can be of any help. |
Would be great to get a review on this |
This has probably broken: julianschill/klipper-led_effect#223 |
I reused the code made by julianschill one year ago on this pull request #5788 and correct something KevinOConnor say about
raise self.printer.config_error()
maybe now the pull request by accepted.for the short description made by julianschill
Configuration made by me and use on my BLV MGN Cube:
I use this script https://github.com/Elenedeath/klipper-neopixel to have a working panel with 3 different information on it. this is a little video to show it in action https://www.youtube.com/watch?v=7i_VIg28kKw
this is my start gcode:
and i can chain another neopixel without the need to specific another gpio for it, only need a new group.
on this example, i have status_panel1 for print_percent, status_panel2 for extruder_temp and status_panel3 for bed_temp
ps: i closed and reopen a new pr like this all my commits are signed off correctly #6445
Signed-off-by: Brochard Pierre elenedeath@gmail.com