-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update for some extra adaptive info #6664
base: master
Are you sure you want to change the base?
Conversation
Small PR to clarify and add some points about exclude_object and properly defined gcode being needed for adaptive meshing. Thanks James Signed-off-by: James Hartley <james@hartleyns.com>
is that a new mesh will be generated for each print if adaptive meshing is used. | ||
EXCLUDE_OBJECT_DEFINE gcode needs to be present in the Gcode file, which can be procesed in | ||
with a slicer plugin, moonraker or by slicer specific functions, see [Slicers.md](Slicers.md), | ||
also [exclude_object] should be in the configuration.It is expected that each Gcode file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space before "It" and capitalize Moonraker
using exclude_object support. The flavor should be set to Klipper and the | ||
label object setting set to "Firmware Specific", making sure all options | ||
for Label Object and Exclude Object are enabled. | ||
Other slicers that dont have this functionality can be processed through a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont -> don't
Thanks. I will commit when you are ready. FWIW, I didn't understand the new wording in Bed_Mesh.md . -Kevin |
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
Small PR to clarify and add some points about exclude_object and properly defined gcode being needed for adaptive meshing.
Also some extra info in Slicers.md to clarify other slicers, and Orca arc features(i can split these out if needed)
Thanks
James
Signed-off-by: James Hartley james@hartleyns.com