Include new async / await language feature to make parallel executions possible #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt functionaity. Also added unit tests.
KoCMoHaBTa
requested changes
Sep 12, 2022
There was a problem hiding this comment.
- All async protocol requirements should be converted to protocol extensions that calls the original function with a continucation in order to maintain backward compatibility.
- Remove the
Asyncsuffix from all method names, because it is redundant with theasynckeyword. - All async functions should not return Optional value just because the completion handler return an Optional - that's because the completion handlers return either the result or an error. For async functions they should either throw an error or return non-optional result. The only exception from that case would be where the Optional value make sense and is valid result.
- All async test functions that calls throwing code should be made
throws, so there will be no need to force unwrap errors.
| @@ -17,6 +17,9 @@ public protocol CredentialsProvider { | |||
| ///Provides credentials in an asynchronous manner. Can be implemented in a way to show a login screen. | |||
| func credentials(handler: @escaping (Username, Password) -> Void) | |||
|
|
|||
| @available(iOS 13, tvOS 13.0.0, macOS 10.15, *) | |||
| func credentialsAsync() async -> (Username, Password) | |||
There was a problem hiding this comment.
This should not be a protocol requirement, but a protocol extension with the implementation.
Remove the Async suffix from the method name.
These should be applied to all similar cases.
| @@ -61,6 +70,14 @@ extension IdentityManager { | |||
| handler?(error) | |||
| } | |||
| } | |||
|
|
|||
| @available(iOS 13, tvOS 13.0.0, macOS 10.15, *) | |||
| public func forceAuthenticateAsync() async throws { | |||
There was a problem hiding this comment.
Directly call the respective forceAuthenticate using a continuation.
| @@ -63,6 +63,23 @@ open class DefaultAccessTokenRefresher: AccessTokenRefresher { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| @available(iOS 13, tvOS 13.0.0, macOS 10.15, *) | |||
| open func refreshAsync(using requestModel: AccessTokenRefreshRequest) async throws -> AccessTokenResponse? { | |||
There was a problem hiding this comment.
The result should not be optional. It should throw an error (eg. MHIdentityKitError.Reason.invalidAccessTokenResponse) if there is no AccessTokenResponse.
This should be applied to all similar cases.
|
|
||
| let manager = OAuth2IdentityManager(flow: Flow(e: XCTestExpectation(description: "XCTestCase Default Expectation")), refresher: Refresher(e: XCTestExpectation(description: "XCTestCase Default Expectation")), storage: InMemoryIdentityStorage(), authorizationMethod: .header) | ||
|
|
||
| let request1 = try! await manager.authorizeAsync(request: URLRequest(url: URL(string: "http://foo.bar")!), forceAuthenticate: false) |
There was a problem hiding this comment.
Make the test function throwing, so there will be no need to force unwrap the error.
This should be applied to all similar cases.
…ix from all method names, async functions do not return optional value just because the handler does it, async test functions calling throwing code marked as throwing.
KoCMoHaBTa
requested changes
Sep 16, 2022
MHIdentityKit/Infrastructure/CredentialsProvider/AnyCredentialsProvider.swift
Outdated
Show resolved
Hide resolved
MHIdentityKit/Infrastructure/CredentialsProvider/CredentialsProvider.swift
Outdated
Show resolved
Hide resolved
MHIdentityKit/Infrastructure/IdentityManager/IdentityManager.swift
Outdated
Show resolved
Hide resolved
MHIdentityKit/Infrastructure/IdentityManager/IdentityManager.swift
Outdated
Show resolved
Hide resolved
MHIdentityKit/OAuth2/Flows/ResourceOwnerPasswordCredentialsGrantFlow.swift
Outdated
Show resolved
Hide resolved
MHIdentityKit/OAuth2/Flows/ResourceOwnerPasswordCredentialsGrantFlow.swift
Outdated
Show resolved
Hide resolved
MHIdentityKit/OAuth2/Flows/ResourceOwnerPasswordCredentialsGrantFlow.swift
Outdated
Show resolved
Hide resolved
MHIdentityKit/OAuth2/Flows/ResourceOwnerPasswordCredentialsGrantFlow.swift
Outdated
Show resolved
Hide resolved
KoCMoHaBTa
requested changes
Sep 16, 2022
KoCMoHaBTa
requested changes
Sep 21, 2022
| @@ -11,73 +11,74 @@ import Foundation | |||
| import XCTest | |||
| @testable import MHIdentityKit | |||
|
|
|||
| @available(iOS 13, tvOS 13.0.0, macOS 10.15, *) | |||
There was a problem hiding this comment.
This test should not be changed.
There was a problem hiding this comment.
So to bring it back as it was before?
There was a problem hiding this comment.
Yes, i have no idea why you changed that test.
KoCMoHaBTa
approved these changes
Oct 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.